Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CI to GitHub Actions #488

Closed
wants to merge 3 commits into from
Closed

Migrate CI to GitHub Actions #488

wants to merge 3 commits into from

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Apr 10, 2020

Travis doesn't seem to work for about two weeks. (I can confirm that it is not working at #484)

...And, Travis is very slow. It would be nice to migrate to GitHub Actions.

@jeehoonkang
Copy link
Contributor

Thanks for suggestion! I'd like to ask if this practice (migrating to Github Actions) is a popolar option for Rust projects these days. If so, I'm happy to merge this PR.

And it seems this PR itself is not tested with a CI. Do you know how to check if it actually works?

@taiki-e
Copy link
Member Author

taiki-e commented Apr 10, 2020

I'd like to ask if this practice (migrating to Github Actions) is a popolar option for Rust projects these days.

rustup, clippy, rayon, hyper, etc. have migrated to Github Actions.
And rust-lang/rust repository currently evaluating the migration: https://blog.rust-lang.org/inside-rust/2020/04/07/update-on-the-github-actions-evaluation.html
As far as I know, in many of these cases the CI time seems to have been reduced.

And it seems this PR itself is not tested with a CI. Do you know how to check if it actually works?

Oops, this is probably due to I have submitted this PR from a folk repository. I'll re-submit from this repository's branch.

@taiki-e taiki-e closed this Apr 10, 2020
@taiki-e taiki-e mentioned this pull request Apr 10, 2020
Merged
@taiki-e
Copy link
Member Author

taiki-e commented Apr 10, 2020

I'll re-submit from this repository's branch.

Submitted #489

bors bot added a commit that referenced this pull request Apr 10, 2020
@bors @taiki-e
Merge #489
0599b8e 
489: Migrate CI to GitHub Actions r=jeehoonkang a=taiki-e

Replaces #488

Co-authored-by: Taiki Endo <te316e89@gmail.com>
@taiki-e taiki-e deleted the github-actions branch April 10, 2020 11:44
exrook pushed a commit to exrook/crossbeam that referenced this pull request Oct 7, 2020
@chmanchester
Don't add --color when --json is passed to rustc. fixes crossbeam-rs#488
fc256ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @jeehoonkang